Improve formulation builder disabled-state accessibility#1226
Conversation
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
BigSimmo
added
the
skip-branch-sync
Cursor
📝 WalkthroughWalkthroughThe formulation builder now uses explicit disabled navigation styling without reduced text opacity. Browser tests cover disabled focus behavior, enabled transitions, and axe violations. Documentation records the final branch, reviewed scope, superseded PRs, and hosted-check requirements. ChangesFormulation accessibility and review status
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…cessibility-final-14d4 Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/components/formulation/formulation-builder-page.tsx (1)
681-681: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueConsider extracting shared disabled-state classes.
Both buttons repeat the same
disabled:cursor-not-allowed disabled:border-[color:var(--border)] disabled:bg-[color:var(--surface-inset)]string. A small shared constant (e.g.disabledNavClasses) would prevent future drift between the two buttons' disabled treatment.Also applies to: 691-691
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/formulation/formulation-builder-page.tsx` at line 681, Extract the repeated disabled-state utility classes from the two navigation buttons into a shared constant such as disabledNavClasses, then interpolate or reuse that constant in both className values so their disabled styling remains synchronized.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/components/formulation/formulation-builder-page.tsx`:
- Line 681: Extract the repeated disabled-state utility classes from the two
navigation buttons into a shared constant such as disabledNavClasses, then
interpolate or reuse that constant in both className values so their disabled
styling remains synchronized.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 3455b4c8-904e-42d1-bbdc-8c233aea60ee
📒 Files selected for processing (4)
docs/branch-review-ledger.mddocs/outstanding-issues.mdsrc/components/formulation/formulation-builder-page.tsxtests/ui-formulation.spec.ts
2 participants
Summary
disabledsemantics while keeping labels readable in light, dark, and forced-colors modesRAG impact: no retrieval behaviour change — UI-only disabled-state styling; no retrieval, ranking, answer, or source behavior changed.
Verification
npm run verify:pr-local— passed on this clean current-main branch; includes build, client-bundle secret scan, 3,421 unit tests, and offline RAG fixture validationnpm run verify:ui— equivalent product/test content passed all seven formulation journeys in earlier hosted Production UI; this final branch requires its own clean hosted Production UI before mergenpm run verify:release— not run; provider-backed and not required for this UI-only changenpm run verify:cheap: 3,421/3,421 passedRisk and rollout
8cd8cb01; no database or migration rollback is involved.Clinical Governance Preflight
N/A — UI-only disabled-state presentation; no ingestion, answer generation, retrieval/ranking, source rendering, document access, privacy, production environment, or clinical output behavior changed.
Notes
agent/formulation-disabled-contrastworktree remains preserved but unavailable. This PR does not modify or discard it.skip-branch-sync; merge only after all required hosted checks, especially Production UI, are green.Summary by CodeRabbit
Bug Fixes
Tests
Documentation